feat: add JS implementation for math/base/special/sicif
#7746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: passed
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: passed
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
stdlib-bot
added
Math
anandkaranubc
added
Feature
Coverage Report
The above coverage report was generated for the changes in this PR. |
anandkaranubc
commented
Jul 26, 2025
| v = sicif( x[ i ] ); | ||
|
|
||
| t.strictEqual( ulpdiff( v[ 0 ], si[ i ] ) <= 3, true, 'returns expected value within 3 ulp' ); | ||
| t.strictEqual( ulpdiff( v[ 1 ], ci[ i ] ) <= 1006, true, 'returns expected value within 1006 ulp' ); |
There was a problem hiding this comment.
Sorry, I am still a little unclear why this difference is higher than others. I checked the implementation multiple times and the block that gets triggered through this test suite, seems all ok to me. Can I get some guidance on this please?
anandkaranubc
commented
Jul 26, 2025
Comment on lines
+160
to
+179
| if ( x > FOUR ) { | ||
| s = sinf( x ); | ||
| c = cosf( x ); | ||
| z = f32( ONE / f32( x*x ) ); | ||
| if ( x < EIGHT ) { | ||
| f = f32( polyvalFN4( z ) / f32( x * polyvalFD4( z ) ) ); | ||
| g = f32( f32( z * polyvalGN4( z ) ) / polyvalGD4( z ) ); | ||
| } else { | ||
| f = f32( polyvalFN8( z ) / f32( x * polyvalFD8( z ) ) ); | ||
| g = f32( f32( z * polyvalGN8( z ) ) / polyvalGD8( z ) ); | ||
| } | ||
| si = f32( f32( HALF_PI - f32( f*c ) ) - f32( g*s ) ); | ||
| if ( sgn ) { | ||
| si = f32( -si ); | ||
| } | ||
| ci = f32( f32( f*s ) - f32( g*c ) ); | ||
| out[ offset ] = si; | ||
| out[ offset + stride ] = ci; | ||
| return out; | ||
| } |
There was a problem hiding this comment.
This is the block. I also can confirm that the operator precedence and order is correctly followed too...
According to C rules.
There was a problem hiding this comment.
This is the reference code block:
s = sinf(x);
c = cosf(x);
z = 1.0/(x*x);
if( x < 8.0 )
{
f = polevlf( z, FN4, 6 ) / (x * p1evlf( z, FD4, 7 ));
g = z * polevlf( z, GN4, 7 ) / p1evlf( z, GD4, 7 );
}
else
{
f = polevlf( z, FN8, 8 ) / (x * p1evlf( z, FD8, 8 ));
g = z * polevlf( z, GN8, 8 ) / p1evlf( z, GD8, 9 );
}
*si = PIO2F - f * c - g * s;
if( sign )
*si = -( *si );
*ci = f * s - g * c;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progresses #649
Description
This pull request:
math/base/special/sicifRelated Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers